javascript - Directives with Isolated scope versions conflict -


in angular app, have directive "editable". written on angular version 1.2.0-rc.2 , worked well, when upgraded framework version 1.2.13 - directive broke. checked capability other versions, , confused, because directive works 3 versions: 1.2.0rc1, 1.2.0-rc.2 , 1.2.0-rc.3

in new versions directive works 2 ugly edits: 1. directive's property "terminal" set "true" 2. compile element in "link" function

directive have simple logic:

  1. show savedvalue
  2. click on button "edit" -> show input new value
  3. click on button "ok" save value - > show new savedvalue

here code:

  1. this version works: http://plnkr.co/edit/vhzvzk?p=preview
  2. this version broken: http://plnkr.co/edit/nffddj?p=preview
  3. this version works new insertions: http://plnkr.co/edit/7msiy0?p=preview

so, have questions:

  1. why it's happens?
  2. what differences between 1.2.0-rc* versions , other, brake down directive.
  3. is there way, better compile directive , adding terminal property repair directive, because many other directives broken too?

first understanding

they changed in way contents compiled against determined scope in case of isolated scope.

breaking changes version 1.2.0

please see breaking changes brought version 1.2.0 :

  • $compile:
    • due d0efd5ee, child elements defined either in application template or in other directives template not isolate scope. in theory, nobody should rely on behavior, rare - in cases isolate directive has template.
    • due 909cabd3, directives without isolate scope not isolate scope isolate directive on same element. if code depends on behavior (non-isolate directive needs access state within isolate scope), change isolate directive use scope locals pass these explicitly.

in specific case, edit button cannot access properties , methods implemented on isolated scope. able temporarily in "rc" versions.

fast solution

don't use isolated scope directive.

deeper solution

you doing quite weird. create isolated scope ngmodel binded scope used directive.

but, working ngmodel directive doesn't work way. have require ngmodelcontroller instance added ngmodel directive, using directive property called require, fill name of directive requiring controller of, "ngmodel". forth argument of link function refer ngmodelcontroller instance quite documented on angular documentation.

so ! :

  • don't use isolated scope when don't need it
  • remember isolated scope not directly accessible on element anymore, except using $$childhead property of course ... should not !


Comments

Post a Comment

Popular posts from this blog

visual studio - vb.net filter binding source by time -

Image
hi there have database date/time (highlighted in red in image below) fields , formatting medium time shown below. and field type , format of log_in_time field.. i've connected database vb.net project , i'm using following code filter binding source log_in_time field of database. i'm using datetimepicker input source. note logouttime datetimepicker code.. private sub logintime_valuechanged(byval sender object, byval e system.eventargs) handles logintime.valuechanged, logintime.keypress 'filter binding source input data try '30-dec-99 default date time paymentdetailsbindingsource.filter = "log_in_time = '30-dec-99 " & logintime.text & "'" catch ex exception end try end sub the format of datetimepicker set custom format hh:mm tt problem above code not work, returns empty search result.. doing wrong appreciated.. thanks.. as per comment above, issue including more (or ...
Read more

php - SPIP: From Tag directly to an article -

i work spip , plugin called tagsphere works fine tags in spip. have tag groupe put 1 article tag. when click on tag in tagsphere send me before menu can see articles linked tag. want send me directly article without see tag menu before. here code model of thagsphere: <div id="tagsphere-#env{id_article}"> <ul> <boucle_mot(mots){id_groupe ?}> <li>[<a href="#url_mot">(#titre)</a>]</li> </boucle_mot> </ul> </div> anybody idea? if want skip tag page, have link directly article. <b_article> block prevents display tag if no article linked. <div id="tagsphere-#env{id_article}"> <ul> <boucle_mot(mots){id_groupe ?}> <b_article> <li> <a<boucle_article(articles){...
Read more

jquery - isAjaxRequest always return false -

i got error message 404,'model has not been saved' following code my action controller public function actionextend($id) { $model=$this->loadmodel($id); if(yii::app()->request->isajaxrequest) { $model->todate = date('y-m-d h:i:s a',(strtotime('next month',strtotime(date('y-01-d'))))); if($model->save()) { yii::app()->end(); } else { throw new chttpexception(404,'model has not been saved'); } } } the jquery call $("#buttonextend<?php echo $this->post_row;?>").click(function(e){ $.ajax({ type: "post", url: "<?php echo yii::app()->createurl('post/extend', array('id' => $data['id'])); ?>", }); }); why not ajax call ? thank help i found response, missed } , function ...
Read more